Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strictmode fixes #413

Merged
merged 8 commits into from
Jan 14, 2019
Merged

Strictmode fixes #413

merged 8 commits into from
Jan 14, 2019

Commits on Jan 9, 2019

  1. fix: prevent unnecessary free disk calculations

    on initialisation calculateFreeDisk was indirectly invoked, which performs IO on the main thread.
    This change avoids calls to getDeviceData() which would trigger these calculations, and adds getters
    for the necessary fields instead. This stops StrictMode violations being reported when initialising
    the SDK.
    fractalwrench committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    6e0c173 View commit details
    Browse the repository at this point in the history
  2. test: simplify test teardown using a runlistener

    JUnit offers a RunListener, which has a method that is invoked after each test is completed.
    Specifying this is preferable to using @after for teardown, as we can cancel asynchronous tasks from
    one place only in this manner.
    fractalwrench committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    f470e4d View commit details
    Browse the repository at this point in the history
  3. fix: cache result of device root check

    By default, we should cache the result of whether the device is rooted or not, as the result is
    unlikely to change between app launches and the calculation requires IO.
    fractalwrench committed Jan 9, 2019
    Configuration menu
    Copy the full SHA
    def8d3e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fa955c7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e0e708 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2019

  1. Configuration menu
    Copy the full SHA
    03fcfb2 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Configuration menu
    Copy the full SHA
    d6ba58a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3836b0f View commit details
    Browse the repository at this point in the history