-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strictmode fixes #413
Merged
Merged
Strictmode fixes #413
Commits on Jan 9, 2019
-
fix: prevent unnecessary free disk calculations
on initialisation calculateFreeDisk was indirectly invoked, which performs IO on the main thread. This change avoids calls to getDeviceData() which would trigger these calculations, and adds getters for the necessary fields instead. This stops StrictMode violations being reported when initialising the SDK.
Configuration menu - View commit details
-
Copy full SHA for 6e0c173 - Browse repository at this point
Copy the full SHA 6e0c173View commit details -
test: simplify test teardown using a runlistener
JUnit offers a RunListener, which has a method that is invoked after each test is completed. Specifying this is preferable to using @after for teardown, as we can cancel asynchronous tasks from one place only in this manner.
Configuration menu - View commit details
-
Copy full SHA for f470e4d - Browse repository at this point
Copy the full SHA f470e4dView commit details -
fix: cache result of device root check
By default, we should cache the result of whether the device is rooted or not, as the result is unlikely to change between app launches and the calculation requires IO.
Configuration menu - View commit details
-
Copy full SHA for def8d3e - Browse repository at this point
Copy the full SHA def8d3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa955c7 - Browse repository at this point
Copy the full SHA fa955c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e0e708 - Browse repository at this point
Copy the full SHA 9e0e708View commit details
Commits on Jan 11, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 03fcfb2 - Browse repository at this point
Copy the full SHA 03fcfb2View commit details
Commits on Jan 14, 2019
-
Configuration menu - View commit details
-
Copy full SHA for d6ba58a - Browse repository at this point
Copy the full SHA d6ba58aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3836b0f - Browse repository at this point
Copy the full SHA 3836b0fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.