Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native): Add interface for clearing a tab #582

Merged

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented Sep 4, 2019

The current revision is missing an interface for clearing a tab.

Tests

  • Manually and using a new automated test

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to add a changelog entry for when this branch is eventually merged into master on bugsnag-android. LGTM - nice catch!

@kattrali
Copy link
Contributor Author

kattrali commented Sep 4, 2019

Thanks for the quick review! Added changelog entry.

@kattrali kattrali merged commit 96fe42e into v4.15.x-unity-backport Sep 4, 2019
@kattrali kattrali deleted the kattrali/fix-missing-native-clear-tab branch September 4, 2019 14:54
@kattrali
Copy link
Contributor Author

kattrali commented Sep 4, 2019

I just re-read your comment - everything on the backports branch is already present in master (This change in particular was in #505 which was released in 4.16.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants