Bump version for next release #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
bump-version
branch
from
38f9504
to
b8db278
Compare
tomlongridge
previously requested changes
Jan 8, 2020
There was a problem hiding this comment.
In addition to these comments, can you take a look at the ordering/grouping to make it a bit more logical (e.g. androidx next to or grouped with modularisation and Kotlin comments as they are structural and not concerned with the functionality of the Unity library).
Also, where changes refer to the Android API, perhaps these should be omitted (if not relevant to a Unity user) or clarified to make it clear that it doesn't affect the Unity API.
fractalwrench
force-pushed
the
bump-version
branch
from
b8db278
to
87d2424
Compare
fractalwrench
dismissed
tomlongridge’s stale review
Ordered structural changes at the top, grouped internal error reports into one description, and clarified a few PRs which are specific to android
kattrali
previously requested changes
Jan 8, 2020
fractalwrench
force-pushed
the
bump-version
branch
from
87d2424
to
b1ee9d9
Compare
kattrali
reviewed
Jan 8, 2020
Co-Authored-By: Delisa <kattrali@users.noreply.github.com>
kattrali
approved these changes
Jan 9, 2020
tomlongridge
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the version to 4.7.0 for the next release. This changeset includes:
This has been tested by running the example app against an emulator/simulator and verifying that an error is captured by both iOS + Android.