-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixed a crash on reportNetworkRequestSpan when networkRequestCallback…
… is not set in the configuration
- Loading branch information
Robert
committed
Jun 21, 2024
1 parent
9765b81
commit 6937044
Showing
5 changed files
with
81 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
features/fixtures/ios/Scenarios/ManualNetworkSpanCallbackNotSetScenario.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // | ||
| // ManualNetworkSpanCallbackNotSetScenario.swift | ||
| // Fixture | ||
| // | ||
| // Created by Robert B on 21/06/2024. | ||
| // | ||
|
|
||
| import BugsnagPerformance | ||
| import os | ||
|
|
||
| class MyCallbackNotSetNetworkDelegate: NSObject { | ||
| static let shared = MyCallbackNotSetNetworkDelegate() | ||
| public let urlConfiguration = URLSessionConfiguration.default | ||
| public var urlSession: URLSession! | ||
|
|
||
| private override init() { | ||
| super.init() | ||
| self.urlSession = URLSession(configuration: urlConfiguration, delegate: self, delegateQueue: OperationQueue()) | ||
| } | ||
| } | ||
|
|
||
| extension MyCallbackNotSetNetworkDelegate : URLSessionDataDelegate { | ||
| func urlSession(_ session: URLSession, task: URLSessionTask, didFinishCollecting metrics: URLSessionTaskMetrics) { | ||
| BugsnagPerformance.reportNetworkRequestSpan(task: task, metrics: metrics) | ||
| } | ||
| } | ||
|
|
||
| @objcMembers | ||
| class ManualNetworkSpanCallbackNotSetScenario: Scenario { | ||
|
|
||
| func query(string: String) { | ||
| let url = URL(string: string, relativeTo: fixtureConfig.reflectURL)! | ||
| MyCallbackNotSetNetworkDelegate.shared.urlSession.dataTask(with: url).resume() | ||
| } | ||
|
|
||
| override func configure() { | ||
| super.configure() | ||
| config.networkRequestCallback = nil | ||
| } | ||
|
|
||
| override func run() { | ||
| query(string: "?status=200") | ||
| } | ||
| } |