Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a crash on reportNetworkRequestSpan #277

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

robert-smartbear
Copy link
Contributor

Goal

Prevent a crash when User calls reportNetworkRequestSpan without setting networkRequestCallback on BugsnagPerformanceConfiguration

Changeset

Added a safeguard preventing a null being assigned to networkRequestCallback_ in BugsnagPerformanceImpl class

Testing

E2E tests

@robert-smartbear robert-smartbear force-pushed the robert/plat-12329-crash-on-report-network-span branch from 6937044 to b5435d5 Compare June 21, 2024 12:59
Copy link

BugsnagPerformance.framework binary size did not change - 459,640 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +24  +0.0%     +24    __TEXT,__text
  -0.1%     -24  -0.1%     -24    [__TEXT]
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@robert-smartbear robert-smartbear merged commit 10c8e41 into next Jun 24, 2024
23 checks passed
@robert-smartbear robert-smartbear deleted the robert/plat-12329-crash-on-report-network-span branch June 24, 2024 09:05
@robert-smartbear robert-smartbear mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants