[PLAT-6798] Improve breadcrumbs performance with async file I/O #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nickdowell
changed the title
nickdowell
changed the title
kattrali
approved these changes
Jun 22, 2021
nickdowell
commented
Jun 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To reduce the overhead of leaving breadcrumbs by performing filesystem I/O on a background queue.
Changeset
Breadcrumbs are now stored in memory as a linked list of JSON encoded C strings that are read at crash time or for calls to
notify().File writing now occurs asynchronously on a dedicated serial
dispatch_queueto free up the calling thread and avoid provoking filesystem contention.Use of
@synchronizedand customized getters & setters inBugsnagBreadcrumbhas been removed - breadcrumbs objects are not shared across threads so there is no need for the overhead.Testing
Added a unit test case to verify that interrupted updates writes to the breadcrumbs linked list do not result in invalid JSON being added to crash reports.
Run full E2E CI