Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6059] Fix empty traces in some edge cases #1425

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

kstenerud
Copy link
Contributor

Goal

The code was incorrectly returning 0 stack trace entries in some error edge cases when it should have been returning the current count. This is a rare edge case, but it may have been contributing to our CI flakes.

Testing

Reran all tests.

@kstenerud kstenerud requested a review from nickdowell July 6, 2022 08:33
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Bugsnag.framework binary size did not change - 815,960 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  +0.0%      +4    __TEXT,__text
  -0.0%      -4  -0.0%      -4    [__TEXT]
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

Copy link
Contributor

@nickdowell nickdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does appear to fix the issue!

https://buildkite.com/bugsnag/bugsnag-cocoa/builds/5920

@kstenerud kstenerud merged commit 2f4011d into next Jul 6, 2022
@kstenerud kstenerud deleted the PLAT-6059-empty-trace branch July 6, 2022 10:22
@nickdowell nickdowell mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants