Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mach handler imports #314

Merged
merged 4 commits into from
Sep 13, 2018
Merged

Fix mach handler imports #314

merged 4 commits into from
Sep 13, 2018

Conversation

kattrali
Copy link
Contributor

Goal

Restore mach handler to full functionality. There was a missing import which led to an undefined define which was required, causing fallback to the signal handler in situations where more debugging information was available.

Tests

  • Manually verified by raising signals, and causing C++/NS exceptions with a custom handler which did not call previous handler. All of these cases are captured correctly and send a single report
  • Automated integration tests

Review

For the submitter, initial self-review:

  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@kattrali kattrali merged commit caef876 into master Sep 13, 2018
@kattrali kattrali deleted the kattrali/fix-mach-handler branch September 13, 2018 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants