Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat)Add callback-free methods to leave breadcrumbs #482

Merged

Conversation

robinmacharg
Copy link
Contributor

Goal

Add additional methods to leave complex breadcrumbs without requiring a callback to be provided.

Design

Two top-level Bugsnag methods largely following the "if started..." pattern established previously.

Changeset

Primarily the Bugsnag class and header, along with unit tests in ObjC anbd Swift. Several other minor typographical changes are included but can be ignored.

Tests

It was only required to check whether breadcrumbs were set correctly and so unit testing sufficed. A simple test for Swift exposure was also included.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

@robinmacharg robinmacharg force-pushed the robin/add-callback-free-constructors-for-complex-breadcrumbs branch from 2ef7317 to 172e291 Compare March 10, 2020 13:40
@robinmacharg robinmacharg marked this pull request as ready for review March 10, 2020 13:41
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending resolution of two minor review comments left inline

Source/Bugsnag.h Outdated Show resolved Hide resolved
Source/Bugsnag.h Show resolved Hide resolved
@robinmacharg robinmacharg merged commit c435f9c into v6 Mar 10, 2020
@robinmacharg robinmacharg deleted the robin/add-callback-free-constructors-for-complex-breadcrumbs branch March 10, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants