[PLAT-5336] Do not report OOM if the device rebooted #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstenerud
approved these changes
Nov 11, 2020
nickdowell
force-pushed
the
nickdowell/oom-reboot-detection
branch
from
9530b1a
to
86cafbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds boot time to the OOM detection's heuristics, to remove a possible source of false positives.
See feature request #545
Changeset
A formatted date representation of
sysctl("kern.boottime")is now stored as"bootTime"inBugsnagSystemState.-[BugsnagClient didLikelyOOM]uses the current and previous values to determine whether a reboot has occurred, and will not report an OOM if so.An assert was added to
-[BugsnagSystemState sync]to make it more obvious when an object that cannot be converted to JSON data has been added to the state.Testing
This has been manually tested by triggering an OOM and then rebooting the device before re-launching the test app.
The need for a device reboot to trigger this does not lend itself to automated testing.