Merge pull request #108 from bugsnag/release-v1.4.1

Release v1.4.1

.travis.yml

@@ -22,8 +22,6 @@ jobs:
       go: "1.10"
     - script: make ci
       go: "1.11"
-    - script: make ci
-      go: "master"
 
     - stage: plain go app tests
       script: make testplain

CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+## 1.4.1 (2019-03-18)
+
+This release fixes a compilation error on Windows.
+Due to a missing implementation in the Go library, Windows users may have to send two interrupt signals to interrupt the application. Other signals are unaffected.
+
+Additionally, ensure data sanitisation behaves the same for both request data and metadata.
+
+### Bug fixes
+
+* Use the `os` package instead of `syscall` to re-send signals, as `syscall` varies per platform, which caused a compilation error.
+
+* Make sure that all data sanitization using `Config.ParamsFilters` behaves the same.
+  [#104](https://github.com/bugsnag/bugsnag-go/pull/104)
+  [Adam Renberg Tamm](https://github.com/tgwizard)
+
 ## 1.4.0 (2018-11-19)
 
 This release is a big non-breaking revamp of the notifier. Most importantly, this release introduces session tracking to Go applications.

request_extractor.go

@@ -60,7 +60,7 @@ func parseRequestHeaders(header map[string][]string) map[string]string {
 
 func contains(slice []string, e string) bool {
 	for _, s := range slice {
-		if strings.ToLower(s) == strings.ToLower(e) {
+		if strings.Contains(strings.ToLower(e), strings.ToLower(s)) {
 			return true
 		}
 	}

request_extractor_test.go

@@ -59,6 +59,7 @@ func TestParseHeadersWillSanitiseIllegalParams(t *testing.T) {
 	headers["password"] = []string{"correct horse battery staple"}
 	headers["secret"] = []string{"I am Banksy"}
 	headers["authorization"] = []string{"licence to kill -9"}
+	headers["custom-made-secret"] = []string{"I'm the insider at Sotheby's"}
 	for k, v := range parseRequestHeaders(headers) {
 		if v != "[FILTERED]" {
 			t.Errorf("expected '%s' to be [FILTERED], but was '%s'", k, v)

sessions/tracker.go

@@ -130,7 +130,12 @@ func (s *sessionTracker) flushSessionsAndRepeatSignal(shutdown chan<- os.Signal,
 			s.config.logf("%v", err)
 		}
 	}
-	syscall.Kill(syscall.Getpid(), sig)
+
+	if p, err := os.FindProcess(os.Getpid()); err != nil {
+		s.config.logf("%v", err)
+	} else {
+		p.Signal(sig)
+	}
 }
 
 func (s *sessionTracker) FlushSessions() {