Prevent potential ConcurrentModificationException when adding callback #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a callback is added while existing callbacks are being iterated through, bugsnag will crash. This changeset addresses this issue by using a ConcurrentLinkedQueue which retains the callback order, but will not crash if new callbacks are added concurrently. This fix has been ported from bugsnag/bugsnag-android#266
fractalwrench
changed the title
Pezzah
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
If a callback is added while existing callbacks are being iterated through, bugsnag will crash. This
changeset addresses this issue by using a ConcurrentLinkedQueue which retains the callback order,
but will not crash if new callbacks are added concurrently. This fix has been ported from
bugsnag/bugsnag-android#266
Tests
Added a unit test for regression testing, otherwise relied on existing coverage.