Allow overriding context set by servlet callback #63

kattrali · 2017-10-10T15:31:59Z

Given a report generated like so and captured from a servlet context:

Report report = bugsnag.buildReport(exception);
report.setContext("custom context");
bugsnag.notify(report);

The context in the final report should retain "custom context" and not be overridden by callbacks.

fractalwrench · 2017-10-10T15:51:36Z

build.gradle

@@ -32,6 +32,8 @@ dependencies {

    testCompile 'junit:junit:4.12'
    testCompile 'org.slf4j:slf4j-jdk14:1.7.25'
+    testCompile 'javax.servlet:javax.servlet-api:3.1.0'
+    testCompile 'org.mockito:mockito-core:2.+'


It would be good to lock this to a specific version.

Add mockito for testing servlet logic

kattrali requested a review from fractalwrench October 10, 2017 15:34

$fractalwrench$

fractalwrench reviewed Oct 10, 2017

View reviewed changes

$fractalwrench$

fractalwrench approved these changes Oct 10, 2017

View reviewed changes

kattrali added 2 commits October 11, 2017 10:35

fix(servlet): Allow overriding context

9838375

Add mockito for testing servlet logic

chore(examples): Lock servlet dep on slf4j

e09f332

kattrali force-pushed the kattrali/fix-overriding-servlet-context branch from f00a3cb to e09f332 Compare October 11, 2017 09:36

kattrali merged commit b78baec into master Oct 11, 2017

kattrali deleted the kattrali/fix-overriding-servlet-context branch October 11, 2017 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow overriding context set by servlet callback #63

Allow overriding context set by servlet callback #63

kattrali commented Oct 10, 2017

$@fractalwrench$ fractalwrench Oct 10, 2017

Allow overriding context set by servlet callback #63

Allow overriding context set by servlet callback #63

Conversation

kattrali commented Oct 10, 2017

fractalwrench Oct 10, 2017

Choose a reason for hiding this comment

$@fractalwrench$ fractalwrench Oct 10, 2017