refactor(session): Rename trackError -> _track and remove from public…

… types
bugsnag · Dec 17, 2019 · b76b550 · b76b550
1 parent cfe31a9
commit b76b550
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 9 deletions.
diff --git a/packages/core/client.js b/packages/core/client.js
@@ -229,7 +229,7 @@ class BugsnagClient {
     event.breadcrumbs = this.breadcrumbs.slice(0)
 
     if (this._session) {
-      this._session.trackError(event)
+      this._session._track(event)
       event.session = this._session
     }
 

diff --git a/packages/core/session.js b/packages/core/session.js
@@ -17,7 +17,7 @@ class Session {
     }
   }
 
-  trackError (event) {
+  _track (event) {
     this[event._handledState.unhandled ? '_unhandled' : '_handled'] += 1
   }
 }

diff --git a/packages/core/test/session.test.js b/packages/core/test/session.test.js
@@ -11,14 +11,14 @@ describe('@bugsnag/core/session', () => {
       expect(s.events).toEqual({ handled: 0, unhandled: 0 })
     })
   })
-  describe('trackError()', () => {
+  describe('track()', () => {
     it('returns the correct data structure', () => {
       const s = new Session()
-      s.trackError({ _handledState: { unhandled: true } })
-      s.trackError({ _handledState: { unhandled: false } })
-      s.trackError({ _handledState: { unhandled: true } })
-      s.trackError({ _handledState: { unhandled: true } })
-      s.trackError({ _handledState: { unhandled: false } })
+      s._track({ _handledState: { unhandled: true } })
+      s._track({ _handledState: { unhandled: false } })
+      s._track({ _handledState: { unhandled: true } })
+      s._track({ _handledState: { unhandled: true } })
+      s._track({ _handledState: { unhandled: false } })
       expect(s.toJSON().events).toEqual({ handled: 2, unhandled: 3 })
     })
   })

diff --git a/packages/core/types/session.d.ts b/packages/core/types/session.d.ts
@@ -7,7 +7,6 @@ declare class Session {
     _handled: number;
     _unhandled: number;
   };
-  public trackError: (event: Event) => void;
 }
 
 export default Session;