Merge pull request #644 from bugsnag/v7-lint-tooling

V7: Migrate all lint tooling to ESLint
bugsnag · Nov 14, 2019 · b892a6e · b892a6e
2 parents 30f928f + 6cddc13
commit b892a6e
Show file tree

Hide file tree

Showing 137 changed files with 7,164 additions and 22,343 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1,8 @@
+dist
+examples
+features
+**/node_modules/**
+fixtures
+scratch
+coverage
+packages/core/types/test/*.js
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -0,0 +1,36 @@
+// eslint config for .js files
+module.exports = {
+  plugins: [
+    'react'
+  ],
+  rules: {
+    'react/jsx-uses-react': 'error',
+    'react/jsx-uses-vars': 'error'
+  },
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    jsx: true,
+    ecmaVersion: 2018
+  },
+  overrides: [
+    // linting for js files
+    {
+      files: ['**/*.js'],
+      extends: [
+        'standard'
+      ]
+    },
+    // linting for ts files
+    {
+      files: ['**/*.ts'],
+      extends: [
+        'eslint:recommended',
+        'plugin:@typescript-eslint/eslint-recommended',
+        'plugin:@typescript-eslint/recommended'
+      ],
+      rules: {
+        '@typescript-eslint/no-explicit-any': 'off'
+      }
+    }
+  ]
+}
diff --git a/TESTING.md b/TESTING.md
@@ -37,15 +37,15 @@ npm run test:unit
 
 ## Type tests
 
-This tests the validity of TypeScript typing files, and lints them using tslint.
+This tests the validity of .d.ts files by attempting to compile a TypeScript program that uses Bugsnag.
 
 ```sh
 npm run test:types
 ```
 
 ## Linting
 
-Lints the entire repo using standardjs rules.
+Lints the entire repo with ESLint. On JavaScript files this uses the [standard](https://github.com/standard/eslint-config-standard) ruleset and on TypeScript files this uses the [@typescript/eslint](https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin) recommended set of rules.
 
 ```sh
 npm run test:lint
@@ -164,4 +164,4 @@ EXPO_PROVISIONING_PROFILE_PATH=xxx \
 EXPO_P12_PATH=xxx \
 EXPO_IOS_DIST_P12_PASSWORD=xxx \
   npm run test:expo:ios
-```
+```
diff --git a/babel.config.js b/babel.config.js
@@ -2,19 +2,19 @@ module.exports = api => {
   if (api) api.cache(false)
   const presets = []
   const plugins = [
-    [ '@babel/plugin-transform-arrow-functions' ],
-    [ '@babel/plugin-transform-block-scoping' ],
-    [ '@babel/plugin-transform-classes', { loose: true } ],
-    [ '@babel/plugin-transform-computed-properties', { loose: true } ],
-    [ '@babel/plugin-transform-destructuring', { loose: true } ],
-    [ '@babel/plugin-transform-member-expression-literals' ],
-    [ '@babel/plugin-transform-property-literals' ],
-    [ '@babel/plugin-transform-parameters', { loose: true } ],
-    [ '@babel/plugin-transform-shorthand-properties' ],
-    [ '@babel/plugin-transform-spread', { loose: true } ],
-    [ '@babel/plugin-transform-template-literals', { loose: true } ],
-    [ '@babel/plugin-proposal-object-rest-spread', { loose: true } ],
-    [ '@babel/syntax-object-rest-spread' ]
+    ['@babel/plugin-transform-arrow-functions'],
+    ['@babel/plugin-transform-block-scoping'],
+    ['@babel/plugin-transform-classes', { loose: true }],
+    ['@babel/plugin-transform-computed-properties', { loose: true }],
+    ['@babel/plugin-transform-destructuring', { loose: true }],
+    ['@babel/plugin-transform-member-expression-literals'],
+    ['@babel/plugin-transform-property-literals'],
+    ['@babel/plugin-transform-parameters', { loose: true }],
+    ['@babel/plugin-transform-shorthand-properties'],
+    ['@babel/plugin-transform-spread', { loose: true }],
+    ['@babel/plugin-transform-template-literals', { loose: true }],
+    ['@babel/plugin-proposal-object-rest-spread', { loose: true }],
+    ['@babel/syntax-object-rest-spread']
   ]
   return { presets, plugins }
 }
diff --git a/dockerfiles/Dockerfile.browser b/dockerfiles/Dockerfile.browser
@@ -8,7 +8,7 @@ WORKDIR /app
 COPY package*.json ./
 RUN npm install
 
-COPY babel.config.js tslint.json lerna.json ./
+COPY babel.config.js lerna.json .eslintignore .eslintrc.js ./
 ADD min_packages.tar .
 COPY bin ./bin
 RUN npx lerna bootstrap

diff --git a/dockerfiles/Dockerfile.ci b/dockerfiles/Dockerfile.ci
@@ -8,7 +8,7 @@ WORKDIR /app
 COPY package*.json ./
 RUN npm install
 
-COPY babel.config.js tslint.json lerna.json ./
+COPY babel.config.js lerna.json .eslintignore .eslintrc.js ./
 ADD min_packages.tar .
 COPY bin ./bin
 RUN npx lerna bootstrap

diff --git a/dockerfiles/Dockerfile.expo-publisher b/dockerfiles/Dockerfile.expo-publisher
@@ -7,7 +7,7 @@ WORKDIR /app
 COPY package*.json ./
 RUN npm install
 
-COPY babel.config.js tslint.json lerna.json ./
+COPY babel.config.js lerna.json .eslintignore .eslintrc.js ./
 COPY packages ./packages
 COPY bin ./bin
 RUN npx lerna bootstrap

diff --git a/dockerfiles/Dockerfile.node b/dockerfiles/Dockerfile.node
@@ -8,7 +8,7 @@ WORKDIR /app
 COPY package*.json ./
 RUN npm install
 
-COPY babel.config.js tslint.json lerna.json ./
+COPY babel.config.js lerna.json .eslintignore .eslintrc.js ./
 ADD min_packages.tar .
 COPY bin ./bin
 RUN npx lerna bootstrap