-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugsnag loading fingerprint.browser.js
instead of fingerprint.react-native.js
#1676
Comments
I removed "@bugsnag/expo": "^7.15.1", from my package JSON, remove all references to this package being loaded into my app, then To confirm, I re-added bugsnag. Then I tried a simpler approach: Appears to be an issue with how Expo and Bugsnag coordinate around which app variation is being executed. Possibly with Fingerprint but could be something else. For now I cannot use Bugsnag until this is fixed :( |
Hi @adriaanbalt. I have tried to reproduce what you are seeing using a brand new expo 43 project and setting the versions of the libraries to the same as you reported. However it appears to be working for me in that clicking on the run in web browser has no effect on the iOS simulator and no errors are thrown. Would you be able to share a simple reproduction example project that demonstrates this and I'd be happy to investigate further. You can send that to us at support@bugsnag.com |
Hi @adriaanbalt, I'm going to close this as we have been unable to reproduce what you are seeing and have no real way to progress this further. If you can provide us with a reproduction example we will be happy to reopen and continue investigations. Thanks |
Environment
"@bugsnag/expo": "^7.16.0",
"react-native": "0.64.3",
"react": "17.0.1",
43.0.2
Describe the bug
I was working in the iOS simulator, my project was working fine. I accidentally clicked "Run in web browser" inside my Metro Bundler browser window.
The below errors appeared
Error 1:
Error 2:
Attempts:
Attempt 1:
The package.json name and the app.json name are the same. I have restated my computer. Two metro bundlers are not running. I haven't edited
AppRegistry.registerComponent
or changed Expo'sAppEntry.js
.Attempt 2:
I went back to an old commit, when I knew this was working, then ran the following commands:
Even after doing this, the errors are still occurring.
Attempt 3:
navigator.userAgent
would only be needed for the browser, not for an iOS or Android device. Which is why I think the issue I'm seeing is related to when I clicked "Run in web browser".Notice that it says
fingerprint.browser.js
andAppEntry.bundle:192932:32
andloadModuleImplementation
. I've a feeling that I may have not set something up for a web version of my app but after clicking that button something automagically changed.I click on
fingerprint.browser.js
in the Call Stack and my editor opened a@bugsnag/cuid/lib/fingerprint.browser.js
file, which has thenavigator.userAgent
code. 🤔 This comes from a bugsnag submodule located hereI re-initialized bugsnag:
$ npx bugsnag-expo-cli init
.This had no change.
For some reason it appears that Bugsnag thinks I'm trying to load my app inside the browser when in fact I'm loading it within the iOS simulator. I looked into the package and it isn't obvious how this distinction is being made.
Thoughts
I'll continue debugging this until I find a solution but if anyone has any ideas I'm all ears. If I find a solution I'll post it here.
Further discussion can be found in this Expo forum post
The text was updated successfully, but these errors were encountered: