Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If internet goes out, Bugsnag slows down all requests 20x #628

Closed
ghost opened this issue Oct 10, 2019 · 4 comments
Closed

If internet goes out, Bugsnag slows down all requests 20x #628

ghost opened this issue Oct 10, 2019 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 10, 2019

We have bugsnag on a server in a location where it has intermittent internet access. Our express server talks to a local database and only uses the internet to send bugsnag reports.

When there is internet, everything works as expected. However, when there is no internet and bugsnag needs to send a bug report, it intercepts all the requests and tries to send the bug report 10 times before it let's the request go through.

Essentially turning a 500ms call to a 10,000 - 15,000ms call.

Steps for Reproduction:

  1. Turn Express server 100% offline.
  2. Make standard request to see how many milliseconds it takes.
  3. Create a bugsnag bug. In our case, we generated 4xx requests.
  4. Now make the same request and watch that the request takes 20 times longer to complete
  5. Turn internet back on.
  6. Make same request a couple times, and watch the requests time speed up again
  7. Rinse and repeat.
@ghost ghost mentioned this issue Oct 10, 2019
@abigailbramble abigailbramble added the feature request Request for a new feature label Oct 11, 2019
@bugsnagbot bugsnagbot added the backlog We hope to fix this feature/bug in the future label Oct 11, 2019
@abigailbramble
Copy link

Hi @bgold0 thanks for the report!
We are looking into adding support for offline operation where error reports would be delivered when a connection is re-established.

@bugsnagbot bugsnagbot added scheduled Work is starting on this feature/bug and removed backlog We hope to fix this feature/bug in the future labels Oct 14, 2019
@mattdyoung
Copy link
Contributor

@bgold0

We've started looking into whether we could fix the root cause of this slow down in advance of adding offline support.

We haven't so far been able to reproduce the behavior you describe though. We've tried setting up a test with an Express server with 30 parallel processes sending an error to the Bugsnag API 100 times in quick succession. We haven't been able to measure any difference in the time taken even when making the end-point unresponsive causing all API requests to timeout and fail.

Are you able to provide a reproduction case?

@mattdyoung mattdyoung added awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. and removed feature request Request for a new feature scheduled Work is starting on this feature/bug labels Oct 15, 2019
@ghost
Copy link
Author

ghost commented Oct 15, 2019

Hey @mattdyoung, I appreciate the update and trying to take care of the issue. Anyway you can send the source of you trying to reproduce it? It would save me some time in reproducing a working version for you.

@mattdyoung
Copy link
Contributor

Hi @bgold0

Attached is our attempt to reproduce. Hopefully you can spot what's different in your usage and adapt the reproduction case.

Thanks!
bugsnag-express-offline.zip

@bugsnagbot bugsnagbot added the scheduled Work is starting on this feature/bug label Oct 21, 2019
@mattdyoung mattdyoung removed the scheduled Work is starting on this feature/bug label Oct 21, 2019
@mattdyoung mattdyoung removed the awaiting feedback Awaiting a response from a customer. Will be automatically closed after approximately 2 weeks. label Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants