Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-react): export types #1009

Merged
merged 3 commits into from
Aug 21, 2020
Merged

feat(plugin-react): export types #1009

merged 3 commits into from
Aug 21, 2020

Conversation

bengourley
Copy link
Contributor

Re-raising and rebasing #936 so it can run on CI.

I've successfully tested this against a React TypeScript project.

@bengourley bengourley requested a review from a team as a code owner August 20, 2020 13:37
@bengourley bengourley mentioned this pull request Aug 20, 2020
Closed
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Aug 20, 2020 •
edited

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against f027499

djskinner
djskinner approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@djskinner djskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a code perspective (haven't manually tested myself)

@bengourley bengourley merged commit 1d8006e into next Aug 21, 2020
@bengourley bengourley deleted the bengourley/react-export-types branch August 21, 2020 15:06
@imjoehaines imjoehaines mentioned this pull request Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

@twometresteve twometresteve twometresteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bengourley @bugsnagbot @djskinner @twometresteve @dacevedo12