deps(expo): Bump expo modules to match included versions #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
force-pushed
the
bengourley/expo-dep-update
branch
from
76550cd
to
3ee3597
Compare
imjoehaines
approved these changes
Oct 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
@bugsnag/expodepends on someexpo-modules, some of which are bundled with Expo itself. Having a different version of these packages means that multiple versions of the dep ends up on an app, and potentially the one we rely on is outdated (as in the case of #1096).Design
I looked at the versions in
changelogVersions.jsonand theexpo/expo package.json, and used a semver minor range to allow a wider set of compatible modules.Changeset
Updated versions for dependencies in
package.jsons.Testing
Existing unit and end to end test cover the functionality. I also manually tested it on an SDK39 project.