[PLAT-5467] fix(react-native): Ensure unhandled promise rejections are logged out #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
approved these changes
Jan 13, 2021
| } | ||
| }) | ||
| return () => rnPromise.disable() | ||
| } | ||
| } | ||
|
|
||
| // this function is copied in from the promise module, since it's not exported and we can't reference it: |
There was a problem hiding this comment.
Not sure if we need to add the license here too; I guess this isn't a "substantial portion" so maybe not?
There was a problem hiding this comment.
It doesn't seem that substantial to me but IANAL 🤷
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When adding the
onUnhandledevent to the rejection tracker, it inadvertantly prevents the "possibly unhandled rejection" warning from displaying.Fixes #1135.
Design
Unfortunately there was no way to import or reference the original function, so it needed to be copied into this repo. The risk here is that it gets out of date with the original.
Changeset
Added warning log that only gets printed in dev (as per the default).
Testing
Unit tests were updated and manual tests were run.