Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update expo @bugsnag/source-maps dependency #1637

Merged
merged 5 commits into from
Jan 10, 2022
Merged

update expo @bugsnag/source-maps dependency #1637

merged 5 commits into from
Jan 10, 2022

Conversation

djskinner
Copy link
Contributor

@djskinner djskinner commented Jan 6, 2022 •
edited

Goal

Update @bugsnag/source-maps to avail of fixes and improvements when uploading source maps in expo projects

Design

NA

Changeset

  • Bumped the @bugsnag/source-maps dependency in packages/expo/package.json to ^2.3.0 which is the latest release
  • Ran npm i && npx lerna bootstrap which caused several package-lock.json updates
  • Updated lockfiles with rm -rf packages/*/node_modules && npm run bootstrap

Testing

  • Published this branch to a local npm repo (verdaccio)
  • Started a new expo project with expo init
  • Added a .yarnrc with registry "http://localhost:4873/"
  • Ran npx bugsnag-expo-cli init specifying the @bugsnag/source-maps version number that was published to local npm
  • Ran expo build:ios
  • Verified source maps were uploaded to the test project
  • Verified in node_modules that the version of @bugsnag/source-maps being used was `2.3.0z

@github-actions
Copy link

github-actions bot commented Jan 6, 2022 •
edited

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.58 kB 12.80 kB
After 41.58 kB 12.80 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 30554f0

imjoehaines
imjoehaines approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@imjoehaines imjoehaines left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djskinner
Merge branch 'next' into update-expo-bugsnag-source-maps
30554f0 
* next:
  v7.14.2
  Search in all android/app/src/main/java subdirectories for MainApplication.java
@djskinner djskinner merged commit 9cd982a into next Jan 10, 2022
@djskinner djskinner deleted the update-expo-bugsnag-source-maps branch January 10, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjoehaines imjoehaines imjoehaines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djskinner @imjoehaines