Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send time error occurred in payload #165

Merged
merged 3 commits into from
Aug 3, 2016
Merged

Send time error occurred in payload #165

merged 3 commits into from
Aug 3, 2016

Conversation

eanakashima
Copy link

@eanakashima eanakashima commented Aug 3, 2016

We currently show the time the error was received as the starting point in the breadcrumb list, but if the client clock is far off from our server time, it can look like there's a gap between all the breadcrumbs and the error. This adds a "Device.time" timestamp like we have for our mobile notifiers, so we can show the whole breadcrumb list in client time. The new version will look like this, changing the top field from "Error Received" to "Error Occurred" in the UI:

screen shot 2016-08-02 at 6 09 53 pm

👋 @kattrali @wordofchristian

@foxyblocks
Copy link

👍 looks good

@kattrali
Copy link
Contributor

kattrali commented Aug 3, 2016

I think device should be lowercase (though it seems to work both ways?), to match the other implementations. I’ll make a note of it in the API spec though. Looks good ⭐

@eanakashima eanakashima merged commit 4ab44c0 into master Aug 3, 2016
@eanakashima eanakashima deleted the device-time branch August 3, 2016 21:06
@GrahamCampbell
Copy link

This is something we might want to do on the PHP notifier too, in particular if we have batch sending enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants