Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set @bugsnag/core as an optional peer dependency #1735

Merged
merged 2 commits into from May 16, 2022
Merged

Set @bugsnag/core as an optional peer dependency #1735

merged 2 commits into from May 16, 2022

Conversation

gingerbenw
Copy link
Member

Goal

To avoid unmet peer dependency warnings when @bugsnag/core isn't required at runtime

@github-actions
Copy link

github-actions bot commented May 11, 2022 •
edited

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 42.31 kB 12.94 kB
After 42.31 kB 12.94 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against d660d89

@gingerbenw gingerbenw merged commit 5de878f into next May 16, 2022
@gingerbenw gingerbenw mentioned this pull request May 18, 2022
Merged
@gingerbenw gingerbenw deleted the PLAT-5048/optional-peer-dependencies branch August 5, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjoehaines imjoehaines imjoehaines approved these changes

@djskinner djskinner Awaiting requested review from djskinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gingerbenw @imjoehaines