Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-8005] Rename postReportCallback #1743

Merged
merged 3 commits into from
May 26, 2022
Merged

[PLAT-8005] Rename postReportCallback #1743

merged 3 commits into from
May 26, 2022

Conversation

gingerbenw
Copy link
Member

Goal

To improve readability of the callback passed to Bugsnag.notify()

@gingerbenw gingerbenw force-pushed the plat-8005-notify-callback-names branch from c805980 to b43354e Compare May 19, 2022 14:37
@gingerbenw gingerbenw force-pushed the plat-8005-notify-callback-names branch from b43354e to 6e52fbe Compare May 19, 2022 14:37
@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 42.48 kB 12.99 kB
After 42.48 kB 12.99 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 24fb5db

@gingerbenw gingerbenw marked this pull request as ready for review May 23, 2022 09:59
@gingerbenw gingerbenw requested a review from djskinner May 23, 2022 09:59
djskinner
djskinner approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@djskinner djskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gingerbenw gingerbenw merged commit 7d86b63 into next May 26, 2022
@gingerbenw gingerbenw mentioned this pull request May 31, 2022
Merged
@luke-belton luke-belton mentioned this pull request Jun 1, 2022
Closed
@gingerbenw gingerbenw deleted the plat-8005-notify-callback-names branch August 5, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gingerbenw @djskinner