Create web-worker package #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gingerbenw
force-pushed
the
web-worker-package
branch
2 times, most recently
from
62d9486
to
544af03
Compare
gingerbenw
commented
Jan 10, 2023
imjoehaines
reviewed
Jan 16, 2023
imjoehaines
reviewed
Jan 16, 2023
gingerbenw
force-pushed
the
fetch-delivery-plugin
branch
from
193af75
to
43286e3
Compare
gingerbenw
force-pushed
the
web-worker-package
branch
from
b8632ae
to
f970b6c
Compare
gingerbenw
changed the base branch from
fetch-delivery-plugin
to
integration/service-worker-support
gingerbenw
force-pushed
the
web-worker-package
branch
from
f970b6c
to
9560692
Compare
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
gingerbenw
force-pushed
the
web-worker-package
branch
from
52691ca
to
54d807c
Compare
imjoehaines
reviewed
Jan 19, 2023
packages/web-worker/README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| Within a web worker, unhandled errors will also bubble up to the script that initialized the worker, so if you are also using BugSnag in the parent script, you may wish to prevent these errors from being reported a second time: |
There was a problem hiding this comment.
It might be worth just replacing this paragraph and snippet with a link to the docs.
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
gareththackeray
approved these changes
Jan 20, 2023
imjoehaines
approved these changes
Jan 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To support the ability to use bugsnag within a web worker or service worker, including background scripts in chrome extensions
Design
The browser notifier is bundled with many plugins which are either unnecessary, or would need to be rewritten to support service workers, so a new simple worker notifier provides the opportunity to define worker related features off of a stable base
Changeset
Testing