Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service worker support #1915

Merged
merged 52 commits into from
Jan 31, 2023
Merged

Add service worker support #1915

merged 52 commits into from
Jan 31, 2023

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Jan 31, 2023 •
edited

Goal

To support the ability to use BugSnag within a web worker or service worker, including background scripts in chrome extensions

Design

The browser notifier is bundled with many plugins which are either unnecessary, or would need to be rewritten to support service workers, so a new simple worker notifier provides the opportunity to define worker related features off of a stable base

Changeset

  • New web-worker package
  • New delivery-fetch package
  • Refactored CDN upload script
  • Updated pipeline scripts to support new packages
  • Updated plugin-browser-device to support web workers
  • Updated plugin-window-onerror to support web workers

Testing

  • Unit tests added for new packages and changes to existing packages
  • End to end tests added for new packages
  • Manually tested CDN upload script changes with sandbox account
  • Dropped failing Android 6 browser tests

gingerbenw and others added 30 commits January 31, 2023 15:15
@gingerbenw
feat: ✨ create new fetch based delivery system
22d7420
@gingerbenw
test: ✅ update jest config to run delivery-fetch unit tests
17eb1a8
@gingerbenw
docs: 📝 update CHANGELOG.md
0de1902
@gingerbenw
use event.apiKey for delivery if present
122f0b8
@gingerbenw @imjoehaines
Update packages/delivery-fetch/README.md
136594c 
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
@gingerbenw
test: ✅ add test for apiKey inheritance
45a8fbe
@gingerbenw
update package-lock.json
4c90070
@gingerbenw
chore: 🏷️ Update delivery type declaration
b10e54c
@gingerbenw
feat: ✨ create new fetch based delivery system
042fc7c
@gingerbenw
feat: ✨ add new web-worker package
478fa2b
@gingerbenw
test: ✅ add unit tests to web-worker package
27bdee1
@gingerbenw
test: ✅ add end to end tests for web-worker package
fba41b8
@gingerbenw
fix: ♻️ refactor plugin-browser-device to work outside of a browser
119a607
@gingerbenw
docs: 📝 update CHANGELOG.md
6cd0540
@gingerbenw
chore: remove duplicate package in jest config
574481b
@gingerbenw
docs: 📝 update TODO.md
3d2e8c5
@gingerbenw
test: 🧪 add failing test to check for presense of stacktrace
e515b14
@gingerbenw
test: ✅ update test assertion to check stacktrace is not empty
491fc0a
@gingerbenw @imjoehaines
Apply suggestions from code review
5c6506a 
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
@gingerbenw
remove TODO.md
10a1122
@gingerbenw @imjoehaines
Update packages/web-worker/README.md
08c8cd4 
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
@gingerbenw
Refactor parameters for improved guarding
91b5325
@gingerbenw
accept second argument to update component name (default window onerror)
e68a54a
@gingerbenw @imjoehaines
Apply suggestions from code review
23b7eab 
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
@gingerbenw
update README.md
2a88ca7
@gingerbenw
Update packages/web-worker/README.md
4049a43
@gingerbenw
feat: ✨ add unhandled promise rejections plugin to web-worker notifier
8570394
@gingerbenw
update CHANGELOG.md
7b66234
@gingerbenw
docs: 📝 remove unnecessary changelog entry
75adc49
@gingerbenw
update eslint environment in worker script
6bdccdd
gingerbenw and others added 22 commits January 31, 2023 15:15
@gingerbenw
add autoTrackSessions to web-worker notifier and disable as default
dff5d6e
@gingerbenw
add session tracking to web-worker notifier
24993de
@gingerbenw
test: ✅ add e2e test for autoTrackSessions in web-worker notifier
374a5f0
@gingerbenw
test: ✅ check session is not started when not expected
e264cd9
@gingerbenw
test: ✅ check for no unexpected sessions
84c59c5
@gingerbenw
refactor: ♻️ move cdn-upload and size scripts to shared bin
9364675
@gingerbenw
chore: add eslint-env worker scope
e0acd44
@gingerbenw
update cdn-upload script
6f9e9da
@gingerbenw
finalise cdn-upload script changes
282569f
@gingerbenw
build: ➕ install cloudfront, knox, mime and semver to root package
7df7a64
@gingerbenw
update web-worker export name
8435255
@gingerbenw
test: 🧪 significantly expand web-worker browser testing
c58854a
@gingerbenw
ensure types are discovered by typescript compiler
4985c6f
@gingerbenw
fix cdn upload script
5675860
@gingerbenw
add useful comments to web_worker.feature
01d3bb6
@gingerbenw
fix broken test
9e94cce
@gingerbenw @imjoehaines
Update bin/cdn-upload
63af519 
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
@gingerbenw
handle environment varibles for bucket name and distribution id
c1d79b6
@gingerbenw
fix cdn-upload script
2074965
@gingerbenw
remove unhandled rejection masking
c390d79
@gingerbenw
test: 🧪 disable android 7 tests
dff427c
@gingerbenw
remove unnecessary dependencies
2112ffa
@gingerbenw gingerbenw force-pushed the integration/service-worker-support branch from 6de1872 to 2112ffa Compare January 31, 2023 15:28
@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.43 kB 13.34 kB
After 43.45 kB 13.36 kB
± ⚠️ +17 bytes ⚠️ +19 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 2112ffa

@gingerbenw gingerbenw marked this pull request as ready for review January 31, 2023 15:55
@gingerbenw gingerbenw merged commit 04ada58 into next Jan 31, 2023
@gingerbenw gingerbenw mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gingerbenw @tomlongridge