[PLAT-9731] Fix XHR delivery postReportCallback #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
reviewed
Mar 9, 2023
imjoehaines
requested changes
Mar 10, 2023
|
latest changes to the xhr mocks are a bit more sweeping, but a lot more similar to the real thing |
imjoehaines
reviewed
Mar 13, 2023
| @@ -11,14 +11,18 @@ module.exports = (client, win = window) => ({ | |||
| if (req.readyState === win.XMLHttpRequest.DONE) { | |||
| const status = req.status | |||
| if (status === 0 || status >= 400) { | |||
| client._logger.error('Event failed to send…') | |||
| const err = new Error(`Request failed with status ${status}`) | |||
There was a problem hiding this comment.
Maybe worth applying this to sendSession as well — it doesn't look like we currently use/expose the cb parameter there but if that changes in the future then it'd be nice for it to not have the same bug
imjoehaines
approved these changes
Mar 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
To ensure delivery errors are passed to the post report callback when using the
delivery-xml-http-requestpluginDesign
Follow the same implementation as
delivery-x-domain-requestTesting
Added new unit test and update existing test to verify errors are handled correctly