New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ReactNative New architecture #1973
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes LGTM, updated |
…re complete before starting a scenario
…Architecture enabled
…d a new rn0.71 example app
yousif-bugsnag
force-pushed
the
PLAT-8690/new-architecture-fixture
branch
from
July 18, 2023 11:04
dfe6840
to
4579f9e
Compare
yousif-bugsnag
force-pushed
the
PLAT-8690/new-architecture-fixture
branch
from
July 19, 2023 11:11
05b6fea
to
a9c01e8
Compare
yousif-bugsnag
approved these changes
Jul 20, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Support apps using ReactNative New Architecture.
Design
The Bugsnag native components have been adapted to be usable as both Native Modules or Turbo Modules, depending on the configuration of the app being built. A Turbo Module
Spec
was added to define the functions that can be triggered by the existing Bugsnag ReactNative JS code.When loading the Bugsnag ReactNative
NativeClient
we check whether Turbo Modules are enabled and use theTurboModulesRegistry
to access the native code if they are.Android
For Android this involves splitting the Java code into 3 components:
main
sourceset)codegen
class and forwards the method call to the common module@ReactMethod
annotations and delegates to the common moduleiOS
The iOS TurboModule is enabled by using conditional compilation flags (
#ifdef
).Testing
A new test fixture was added for ReactNative 0.71 with New Architecture enabled.