Improved performance of click event breadcrumbs #2094
Conversation
| @@ -21,8 +21,7 @@ module.exports = (win = window) => ({ | |||
| } | |||
| }) | |||
|
|
|||
| const trimStart = /^\s+/ | |||
| const trimEnd = /(^|[^\s])\s+$/ | |||
| const trim = /^\s*([^\s].{0,139}[^\s])?\s*/s | |||
There was a problem hiding this comment.
@lemnik looks like we've got an issue with this regex - perhaps the s at the end? it was modified slightly from the suggestion as it didn't remove the trailing whitespace.
There was a problem hiding this comment.
Yeah, that's certainly what the error indicated, although the /s flag is the dotAll flag. Maybe it's a version compatibility thing and we need to use [.\n] instead of . (assuming dotAll is not available on the target browser)?
There was a problem hiding this comment.
I replaced . with [.\n] and tests failed locally.
For example:
There was a problem hiding this comment.
/^\s*([^\s][\s\S]{0,139}[^\s])?\s*/should do the trick, [\s\S] should be treated the same as . with the dotAll flag set
There was a problem hiding this comment.
It worked! Thanks!
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Looks like your linter has applied some formatting to older entries - can you revert so that only the new entry is added?
AnastasiiaSvietlova
deleted the
PLAT-11199-plugin-interaction-breadcrumbs
branch
Goal
Reduce time it takes gather innerText of a large element
Changeset
Updated RegExp for trimming whitespaces in breadcrumbs for UI click
Testing
Covered by existing unit tests