fix(transports): Switch to @bugsnag/safe-json-stringify for serialization #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion fast-safe-stringify did not fully protect us against circular data structures or objects of arbitrarily large depth. This commit implements our own forked version of a serialization library with some extra features required by us. Fixes #337
kattrali
previously approved these changes
Apr 16, 2018
bengourley
force-pushed
the
improved-json-serialization
branch
from
684deae
to
8d30739
Compare
bengourley
force-pushed
the
improved-json-serialization
branch
from
8d30739
to
4350779
Compare
|
The travis fail is a flake. It is a different browser and a different test that fails each time I trigger a new build. The tests pass when I run them on BrowserStack from my local machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fast-safe-stringify did not fully protect us against circular data structures or objects of arbitrarily large depth. This commit implements our own forked version of a serialization library with some extra features required by us.
Fixes #337.