feat(logger): Allow logger to be set in config #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
force-pushed
the
bengourley/logger-config
branch
from
70e5fde
to
a577878
Compare
Previously configuration would happen _before_ the client.logger() method could be called, so the "[bugsnag] loaded!" message would be printed before the logging could be disabled. This commit allows the logger to be set in the configuration object. Logging can be completely disabled by passing `logger: null`. Fixes #302
bengourley
force-pushed
the
bengourley/logger-config
branch
from
a577878
to
ec36873
Compare
The previous commit adding logger to the configuration increased the bundle size. This should counterbalance that added weight.
|
The reason the error messages can have the property name removed is because we build a message containing the key already in Line 58 in 4132b43 |
Cawllec
reviewed
Apr 19, 2018
| @@ -129,18 +123,6 @@ module.exports = (opts, userPlugins = []) => { | |||
| : bugsnag | |||
| } | |||
|
|
|||
| const getPrefixedConsole = () => { | |||
There was a problem hiding this comment.
This is only available/used inside the browser/index.js exported function correct?
So it's removal shouldn't be a breaking change?
There was a problem hiding this comment.
Correct, it was "private" to that module. It's been moved to browser/config.js where it is now used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously configuration would happen before the client.logger() method could be called, so the "[bugsnag] loaded!" message would be printed before the logging could be disabled. This commit allows the logger to be set in the configuration object. Logging can be completely disabled by passing
logger: null.Fixes #302