fix: Improve behaviour in the case of delivery failure #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logger object was incorrectly invoked as a function, rather than one of its log methods. Also the error logging branch would return out of the function, meaning the onUncauhgtException/onUnhandledRejection callbacks would not be executed.
bengourley
force-pushed
the
fix-logging-calls
branch
from
9c044a3
to
2ef026e
Compare
kattrali
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger object was incorrectly invoked as a function, rather than one of its log methods. Also the error logging branch would return out of the function, meaning the
onUncaughtException/onUnhandledRejectioncallbacks would not be executed.This addresses part of #436.