V7: rename notifyReleaseStages option #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the naming of the notifyReleaseStages option to be enabledReleaseStages to denote the fact that it reflects sessions as well as error reporting. Additionally tweaked the behaviour to match the new spec: - An empty list should be interpreted as all releaseStages being enabled - The default value should be an empty list (instead of null)
bengourley
force-pushed
the
v7-rename-notify-release-stages
branch
from
14d1280
to
2e308ea
Compare
djskinner
approved these changes
Nov 18, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the naming of the notifyReleaseStages option to be enabledReleaseStages to denote the fact that it reflects sessions as well as error reporting. Additionally tweaked the behaviour to match the new spec:
releaseStagesbeing enablednull)