Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7: Remove client device prop #673

Merged
merged 4 commits into from Dec 17, 2019
Merged

V7: Remove client device prop #673

merged 4 commits into from Dec 17, 2019

Conversation

bengourley
Copy link
Contributor

client.device should not exist – device now exists on Event only.

The session payload callbacks are now hooked up to get device info into the session payload.

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Dec 16, 2019 •
edited

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.69 kB 12.33 kB
After 40.65 kB 12.31 kB
± -47 bytes -17 bytes

Generated by 🚫 dangerJS against 66a23b0

djskinner
djskinner approved these changes Dec 16, 2019
View reviewed changes
packages/plugin-browser-session/session.js Outdated Show resolved Hide resolved
@bengourley bengourley merged commit f6f2553 into v7 Dec 17, 2019
@bengourley bengourley deleted the v7-remove-client-device-prop branch December 17, 2019 15:55
@bengourley bengourley mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bengourley @bugsnagbot @djskinner