V7: Move context and breadcrumbs to private properties #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
force-pushed
the
v7-client-state
branch
from
68c2370
to
9e32476
Compare
djskinner
reviewed
Dec 20, 2019
packages/core/config.js
Outdated
| user: { | ||
| defaultValue: () => null, | ||
| message: '(object) user should be an object', | ||
| message: 'user should be an object', |
There was a problem hiding this comment.
Could remove 'user' here? I guess the context would be sufficient to know it was user? Also makes it consistent with the other messages and may save a byte if we're lucky!
There was a problem hiding this comment.
6 bytes after minification!
Comment on lines
+82
to
+88
| getContext () { | ||
| return this._context | ||
| } | ||
|
|
||
| setContext (c) { | ||
| this._context = c | ||
| } |
There was a problem hiding this comment.
Do these need adding to the public interface typedefs?
There was a problem hiding this comment.
yeah – I was in the middle of a big types refactor when I realised this change was needed, so they are in #682 to save a conflict!
djskinner
approved these changes
Dec 20, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the spec, context and breadcrumbs should be private.