feat(browser): Integrate maxEvents functionality with new interface #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure counts can be reset via the static interface as well as the client instance - Rename refresh->resetEventCount - Add method to type definitions
bengourley
commented
Feb 4, 2020
| @@ -68,6 +68,9 @@ declare class Client { | |||
| public use(plugin: Plugin, ...args: any[]): Client; | |||
| public getPlugin(name: string): any; | |||
|
|
|||
| // implemented on the browser notifier only | |||
| public resetEventCount?(): void; | |||
There was a problem hiding this comment.
This seemed like the most reasonable way to implement this. If I did something like class BrowserClient extends Client to add the method only for the browser, it upsets the "universal" interface. Specifically it upset the Angular plugin which does import { Client } from '@bugsnag/js' – it doesn't know if Client should be a Client or BrowserClient since it can be run in Node or Browser.
djskinner
approved these changes
Feb 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refresh->resetEventCount