V7: Update config behaviour and plugin interface #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djskinner
approved these changes
Mar 6, 2020
|
|
||
| function handleXHRError () { | ||
| if (includes(getIgnoredUrls, this[REQUEST_URL_KEY])) { |
There was a problem hiding this comment.
oh, I didn't even notice. Looks like it was!
| const after = process.listeners('uncaughtException').length | ||
| expect(after - before).toBe(1) | ||
| expect(c).toBe(c) |
There was a problem hiding this comment.
What is the purpose of these assertions?
There was a problem hiding this comment.
Appeasing the linter :(
instantiating a client and then not referring to it leads to an unused variable error. If I remove the assignment to client, it errors with the "don't use new for side effects" rule.
I didn't want to ignore the line where it was instantiated, so this seemed like the least bad option. I'm sure there's a better way.
There was a problem hiding this comment.
Fair enough. We can revisit this as part of the TS conversion.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec now stipulates that the only invalid configuration that should throw an error is
apiKey. All others should log a warning and proceed with the default value.The plugin interface has also been updated.
init()is nowload(), and theclient.use()method has been disabled in favour of passing plugins in toconfig.plugins[].Todo: