Allow onError/onSession/onBreadcrumb callbacks with no arguments #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
force-pushed
the
allow-callbacks-with-no-arguments
branch
from
d297d2b
to
fdec85f
Compare
Previously a callback like '() => false' would never be called due to the length check; it had to be written as '_ => false' instead
imjoehaines
force-pushed
the
allow-callbacks-with-no-arguments
branch
from
fdec85f
to
644a6e1
Compare
djskinner
approved these changes
May 26, 2020
bengourley
approved these changes
May 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a callback like
() => falsewould never be called due to the length check; it had to be written as_ => falseinstead (i.e. have at least one argument)