Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-react): Access the window object safely, in case it isn't defined #930

Merged
merged 2 commits into from
Jul 15, 2020
Merged

fix(plugin-react): Access the window object safely, in case it isn't defined #930

merged 2 commits into from
Jul 15, 2020

Conversation

imjoehaines
Copy link
Member

This prevents errors when using SSR as 'window' won't exist

Heavily based on #928 馃檪

@imjoehaines
fix(plugin-react): Access 'window' safely
cea4b1c 
This prevents errors when using SSR as 'window' won't exist
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jul 13, 2020 •
edited

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.56 kB 12.22 kB
After 39.56 kB 12.22 kB
卤 No change No change

Generated by 馃毇 dangerJS against d2025d2

@bengourley bengourley merged commit 25d5f08 into next Jul 15, 2020
@bengourley bengourley deleted the safe-window-reference-react-plugin branch July 15, 2020 15:04
@djskinner djskinner mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imjoehaines @bugsnagbot @bengourley