Add correct handled/unhandled state to notifications #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add laravel test fixture for maze
- Add copy of testing.env to .env during build
…ravel into cawllec/handled-state
…el into cawllec/maze-tests
kattrali
reviewed
Oct 26, 2018
…ravel into cawllec/handled-state
… places in Laravel apps
snmaynard
approved these changes
Oct 31, 2018
|
CI is failing. |
Cawllec
added a commit
that referenced
this pull request
Nov 2, 2018
* Dockerisation: Added dockerfile and updated Readme (#316) * Dockerisation: Added dockerfile and updated Readme * Dockerisation: Added composer installation into docker build * Dockerisation: More example routes/navigation * Dockerisation: Updated wording/flow based on feedback * Dockerisation: Streamlined dockerfile based on feedback * Dockerisation: Added keygen * Add correct handled/unhandled state to notifications (#325) * handledState: Add Laravel Un/handled state checking * Apply fixes from StyleCI (#303) * handledState: Add Laravel Un/handled state checking - Add laravel test fixture for maze * Apply fixes from StyleCI (#304) * handledState: Add Laravel Un/handled state checking - Add copy of testing.env to .env during build * feature: Update maze tests * feature: Add un/handled middleware to client * Apply fixes from StyleCI (#309) * feature: Removed superfluous unit test for unhandledMiddleware * handledState: Removed maze-tests to separate branch * maze-tests: Initial maze fixture commit * Apply fixes from StyleCI (#319) * Handled state: Removed gemfile * Maze-tests: Rebuilt laravel fixture * Maze-tests: Added gemfile and git exceptions * Maze-tests: Added supporting maze steps and environment * Maze-tests: Add unhandled maze feature * Apply fixes from StyleCI (#320) * handledState: Ensure callable is received and called * HandledState: fixed desired class names * Maze-tests: Moved shared server steps into maze-runner * Maze tests: Pushed current changes * Install bugsnag dep from local archive * Maze tests: Added dependencies to package composer.json in fixture * HandledState: Made necessary change to middleware order * MazeTest: Required new steps from maze, qualified gitignore * MazeTests: Added further steps to unhandled feature * Maze-tests: Added auto copying of bugsnag-laravel requirements into fixture * Handled State: Ensure / are escaped correctly, add dependency on PHP changes * Handled state: Add basic handled-state tests * Apply fixes from StyleCI (#324) * HandledState: Added middleware methodology comment block * HandledState: Added scenarios for checking session counts * Apply fixes from StyleCI (#326) * v2.15.0-alpha-1 * HandledState: Added handled and unhandled tests for several different places in Laravel apps * Apply fixes from StyleCI (#327) * HandledState: Fixed fixture route typo * v2.15.0 * DockerDelay: Added delay before pings after docker-composer up (#329) * Revert "DockerDelay: Added delay before pings after docker-composer up (#329)" (#330) This reverts commit 35f319b. * v2.15.0: Bumped changelog date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the correct handled/unhandled state to notifications
Adds end-to-end tests to check the added functionality
Changeset
Added
UnhandledStatemiddleware to determine whether handled or not an event is handledTests
Added unhandled and handled maze-tests for end to end testing of unhandled feature
TODO: Enable session tracking and test
sessionspayload property (Manually tested this, new ordering works correctly)Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: