Dockerisation: Added dockerfile and updated Readme #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin308
suggested changes
Sep 4, 2018
example/laravel56/Dockerfile
Outdated
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends git zip unzip wget | ||
|
|
||
| RUN mkdir /app |
There was a problem hiding this comment.
using the WORKDIR command below will create the required directory
example/laravel56/Dockerfile
Outdated
| RUN mkdir /app | ||
| WORKDIR /app | ||
|
|
||
| COPY . /app/ |
There was a problem hiding this comment.
everything is relative from the WORKDIR once it is set so we can use relative paths here
example/laravel56/Dockerfile
Outdated
|
|
||
| COPY . /app/ | ||
|
|
||
| RUN /app/install_composer.sh |
example/laravel56/Dockerfile
Outdated
|
|
||
| RUN /app/install_composer.sh | ||
|
|
||
| RUN cd /app/ && \ |
There was a problem hiding this comment.
you shouldn't need to change directory here either due to using WORKDIR
| php composer-setup.php | ||
| RESULT=$? | ||
| rm composer-setup.php | ||
| exit $RESULT |
There was a problem hiding this comment.
would it be better to just use the composer image directly so we don't need this script?
There was a problem hiding this comment.
The composer image only runs composer, and isn't designed for running PHP servers unfortunately.
example/laravel56/Dockerfile
Outdated
| FROM php:latest | ||
|
|
||
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends git zip unzip wget |
There was a problem hiding this comment.
it'll make it easier to maintain this dockerfile if we organize these like this
RUN apt-get update && \
apt-get install -y --no-install-recommends \
git \
unzip \
wget \
zip
|
Thanks for the feedback Martin. I've made some updates based on your (and @mikeewhite's in person) feedback, if you could give it another quick look over, that would be great. |
martin308
approved these changes
Sep 5, 2018
|
You cant run the official composer image. It is just a wrapper for the cli. composer/docker#44 (comment) as an example. You might be able to use it as a base and then go from there, but I think this is better. |
Cawllec
added a commit
that referenced
this pull request
Nov 2, 2018
* Dockerisation: Added dockerfile and updated Readme (#316) * Dockerisation: Added dockerfile and updated Readme * Dockerisation: Added composer installation into docker build * Dockerisation: More example routes/navigation * Dockerisation: Updated wording/flow based on feedback * Dockerisation: Streamlined dockerfile based on feedback * Dockerisation: Added keygen * Add correct handled/unhandled state to notifications (#325) * handledState: Add Laravel Un/handled state checking * Apply fixes from StyleCI (#303) * handledState: Add Laravel Un/handled state checking - Add laravel test fixture for maze * Apply fixes from StyleCI (#304) * handledState: Add Laravel Un/handled state checking - Add copy of testing.env to .env during build * feature: Update maze tests * feature: Add un/handled middleware to client * Apply fixes from StyleCI (#309) * feature: Removed superfluous unit test for unhandledMiddleware * handledState: Removed maze-tests to separate branch * maze-tests: Initial maze fixture commit * Apply fixes from StyleCI (#319) * Handled state: Removed gemfile * Maze-tests: Rebuilt laravel fixture * Maze-tests: Added gemfile and git exceptions * Maze-tests: Added supporting maze steps and environment * Maze-tests: Add unhandled maze feature * Apply fixes from StyleCI (#320) * handledState: Ensure callable is received and called * HandledState: fixed desired class names * Maze-tests: Moved shared server steps into maze-runner * Maze tests: Pushed current changes * Install bugsnag dep from local archive * Maze tests: Added dependencies to package composer.json in fixture * HandledState: Made necessary change to middleware order * MazeTest: Required new steps from maze, qualified gitignore * MazeTests: Added further steps to unhandled feature * Maze-tests: Added auto copying of bugsnag-laravel requirements into fixture * Handled State: Ensure / are escaped correctly, add dependency on PHP changes * Handled state: Add basic handled-state tests * Apply fixes from StyleCI (#324) * HandledState: Added middleware methodology comment block * HandledState: Added scenarios for checking session counts * Apply fixes from StyleCI (#326) * v2.15.0-alpha-1 * HandledState: Added handled and unhandled tests for several different places in Laravel apps * Apply fixes from StyleCI (#327) * HandledState: Fixed fixture route typo * v2.15.0 * DockerDelay: Added delay before pings after docker-composer up (#329) * Revert "DockerDelay: Added delay before pings after docker-composer up (#329)" (#330) This reverts commit 35f319b. * v2.15.0: Bumped changelog date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic dockerfile to the Laravel 5.6 example, allow it to be run in a local container.
This not only will allow us to get the examples running inside a container faster, but also is a stepping stone toward end-to-end/maze tests.
An updated readme for the example has also been provided.
Tests
The docker container was manually run, and confirmed to be delivering notifications to Bugsnag.
Review
The example needs to be tested so that the example can be built and run out of the box.