PHP 7 Throwable support: Error handling type declarations have been removed and work in PHP 5.x and PHP 7.x #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PThrowable to maintain 5.x compatibility
| @@ -454,9 +454,9 @@ public function setSendCode($sendCode) | |||
| * @param Array $metaData optional metaData to send with this error | |||
| * @param String $severity optional severity of this error (fatal/error/warning/info) | |||
| */ | |||
| public function notifyException(Exception $exception, array $metaData = null, $severity = null) | |||
| public function notifyException($throwable, array $metaData = null, $severity = null) | |||
There was a problem hiding this comment.
The documentation for this method should probably be updated to indicate a throwable is accepted here
|
Looks good, I'm going to do a few extra tests (and try to resolve the build error on CI). Thanks, @cmstone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.