FIX - Passing compiled modules to traceback_exclude_modules #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iled (.pyc), and the comparison during the stacktrace building will not ignore the related lines because of it.
…le__, so verify the .pyc only on these versions.
… Travis CI image doesn’t contain python 2.6.
|
Thank you for the very thorough report and patch, @kobim. Looking it over now. |
|
Looks great! Thanks for updating the CI config as well. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure.traceback_exclude_modulesreceives a list of modules, and extracts the__file__of each, allowing to skip few modules from appearing in the stacktrace.In Python 2.x, when a compiled module is loaded, it's
__file__property displays the compiled.pycpath, while the running code will appear in the stacktrace with a.pysuffix.This fix replaces the .pyc suffix with a .py, hence enabling the
traceback_exclude_modulesto work as it should.I also added tests reproducing this scenario, and also tweaked .travis.yml to support the new image they deployed recently (https://blog.travis-ci.com/2017-05-04-precise-image-updates).