Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back vendor paths #394

Closed
etiennebarrie opened this issue Nov 16, 2017 · 3 comments
Closed

Bring back vendor paths #394

etiennebarrie opened this issue Nov 16, 2017 · 3 comments

Comments

@etiennebarrie
Copy link

etiennebarrie commented Nov 16, 2017

Before v6.0, Bugsnag was annotating each line of the backtrace, setting inProject to false if the file was not in the project root, or if it was in one of the vendor paths, which defaulted to directories named vendor.

I think this feature should be brought back, because when you use bundle install --deployment, by default it installs the gems inside the project, under vendor/bundle.

Expected behavior

  • I expect to only see my code when I look at an error or event on Bugsnag, not the framework's code or gems.
  • If I need to, I can show the full trace.

Observed behavior

  • All lines of the backtrace end up showing on the dashboard.
  • It seems the grouping algorithm uses the visible lines, so now unrelated events can get grouped together if they share the first line of the stacktrace inside a gem (typically for me it's an HTTP client like Faraday), or even from the stdlib like Net::HTTP (e.g. on Heroku ruby is installed in the project root, under vendor/, see heroku-buildpack-ruby).

Version

  • v6.0.0 and later
@kattrali
Copy link
Contributor

Thanks for the detailed report, @etiennebarrie. This should be fixed in the next patch.

It seems the grouping algorithm uses the visible lines, so now unrelated events can get grouped together, if they share the first line of the stacktrace inside a gem (typically

Which gem is it, typically?

@etiennebarrie
Copy link
Author

Oops sorry updated the description.

@kattrali
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants