Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If ENV['http_proxy'] has port, use it #424

Merged
merged 1 commit into from Feb 19, 2018
Merged

If ENV['http_proxy'] has port, use it #424

merged 1 commit into from Feb 19, 2018

Conversation

cluesque
Copy link
Contributor

@cluesque cluesque commented Feb 1, 2018

... also allow for user and password, if configured

fixes #423

If ENV['http_proxy'] has port, use it
7ecfaba 
... also allow for user and password, if configured

fixes bugsnag#423
@Cawllec
Copy link
Contributor

Cawllec commented Feb 2, 2018 •
edited

LGTM, thanks @cluesque

@Cawllec Cawllec merged commit ec71cb0 into bugsnag:master Feb 19, 2018
Cawllec added a commit that referenced this pull request Feb 19, 2018
@Cawllec
Revert "If ENV['http_proxy'] has port, use it (#424)"
08e7ce4 
This reverts commit ec71cb0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect interpretation of proxy port numbers
2 participants
@cluesque @Cawllec