Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect interpretation of proxy port numbers #423

Closed
cluesque opened this issue Feb 1, 2018 · 0 comments · Fixed by #424
Closed

Incorrect interpretation of proxy port numbers #423

cluesque opened this issue Feb 1, 2018 · 0 comments · Fixed by #424
Labels
feature request Request for a new feature

Comments

@cluesque
Copy link
Contributor

cluesque commented Feb 1, 2018

Expected behavior

When ENV['http_proxy'] is of the form http://192.168.1.2:8888 the port number should be respected.

Observed behavior

Bug reports don't escape because an attempt is made to connect to 192.168.1.2:8888:80, as reported by the sad proxy.

Steps to reproduce

Run a rails app in an environment where ENV['http_proxy'] is of the form http://192.168.1.2:8888.
Force a reportable exception.

Version

6.6.3

Additional information

We discovered this when upgrading from version 5.4.1

cluesque pushed a commit to cluesque/bugsnag-ruby that referenced this issue Feb 1, 2018
... also allow for user and password, if configured

fixes bugsnag#423
@Cawllec Cawllec added the feature request Request for a new feature label Feb 2, 2018
Cawllec pushed a commit that referenced this issue Feb 19, 2018
... also allow for user and password, if configured

fixes #423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants