Update e2e test features to target Ruby 2.6 and Rails 6 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
reviewed
Oct 1, 2019
features/fixtures/rails5/app/Gemfile
Outdated
| @@ -44,7 +44,7 @@ gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby] | |||
| gem 'bugsnag', path: '/bugsnag' | |||
|
|
|||
| # Added at 2018-04-26 10:20:10 +0100 by amoinet: | |||
| gem "clearance", "~> 1.16" | |||
| gem "clearance", "1.16.1" | |||
There was a problem hiding this comment.
Consider making this conditional and comment to justify pinning.
…uby into test-2.6/maze-fixtures
tomlongridge
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds tests against Rails 6 in all of our rails features, and adds additional Rails 5 tests against Ruby 2.6.
These features don't run on CI, but have passed locally.