Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e test features to target Ruby 2.6 and Rails 6 #568

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Update e2e test features to target Ruby 2.6 and Rails 6 #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eebb85d
Test 2.6 / Add 2.6 to test scenarios
Cawllec Sep 24, 2019
247a9fb
Test 2.6: Fix Rails 5 on Ruby 2.2
Cawllec Sep 24, 2019
6040135
Merge branch 'master' into test-2.6/maze-fixtures
Cawllec Oct 1, 2019
c0b6ab3
Test 2.6: Make sure clearance pinning is conditional
Cawllec Oct 1, 2019
e266768
Merge branch 'test-2.6/maze-fixtures' of github.com:bugsnag/bugsnag-r…
Cawllec Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions features/fixtures/rails5/app/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]
# Added at 2018-03-26 15:20:23 +0100 by amoinet:
gem 'bugsnag', path: '/bugsnag'

# Added at 2018-04-26 10:20:10 +0100 by amoinet:
gem "clearance", "~> 1.16"
# Clearance breaks in Ruby < 2.3 and needs to be pinned to `1.16.1`
ruby_version = Gem::Version.new(RUBY_VERSION)
gem "clearance", ruby_version < Gem::Version.new('2.3.0') ? '1.16.1' : '~> 1.16'

gem "mongoid"

Expand Down
6 changes: 5 additions & 1 deletion features/rails_features/api_key.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ Scenario Outline: Setting api_key in environment variable works
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Changing api_key after initializer works
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -58,4 +60,6 @@ Scenario Outline: Setting api_key in environment variable works
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
6 changes: 5 additions & 1 deletion features/rails_features/app_type.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ Scenario Outline: Setting app_type in initializer works
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Changing app_type after initializer works
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -66,4 +68,6 @@ Scenario Outline: Changing app_type after initializer works
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
8 changes: 7 additions & 1 deletion features/rails_features/app_version.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ Scenario Outline: App_version is nil by default
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Setting app_version in initializer works
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -58,6 +60,8 @@ Scenario Outline: Setting app_version in initializer works
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Setting app_version after initializer works
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -84,4 +88,6 @@ Scenario Outline: Setting app_version after initializer works
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
10 changes: 9 additions & 1 deletion features/rails_features/auto_capture_sessions.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ Scenario Outline: Auto_capture_sessions defaults to true
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Auto_capture_sessions can be set to false in the initializer
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -56,6 +58,8 @@ Scenario Outline: Auto_capture_sessions can be set to false in the initializer
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Manual sessions are still sent if Auto_capture_sessions is false
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -84,6 +88,8 @@ Scenario Outline: Manual sessions are still sent if Auto_capture_sessions is fal
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: 100 session calls results in 100 sessions
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -112,4 +118,6 @@ Scenario Outline: 100 session calls results in 100 sessions
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
10 changes: 9 additions & 1 deletion features/rails_features/auto_notify.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Scenario Outline: Auto_notify set to false in the initializer prevents unhandled
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Auto_notify set to false in the initializer still sends handled errors
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -61,6 +63,8 @@ Scenario Outline: Auto_notify set to false in the initializer still sends handle
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Auto_notify set to false after the initializer prevents unhandled error sending
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -84,6 +88,8 @@ Scenario Outline: Auto_notify set to false after the initializer prevents unhand
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Auto_notify set to false after the initializer still sends handled errors
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -115,4 +121,6 @@ Scenario Outline: Auto_notify set to false after the initializer still sends han
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
6 changes: 6 additions & 0 deletions features/rails_features/before_notify.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ Scenario Outline: Rails before_notify controller method works on handled errors
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Rails before_notify controller method works on unhandled errors
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -72,6 +74,8 @@ Scenario Outline: Rails before_notify controller method works on unhandled error
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Inline block on handled errors is called
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -106,4 +110,6 @@ Scenario Outline: Inline block on handled errors is called
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

10 changes: 10 additions & 0 deletions features/rails_features/breadcrumbs.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ Scenario Outline: Request breadcrumb
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: SQL Breadcrumb without bindings
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -67,6 +69,8 @@ Scenario Outline: SQL Breadcrumb without bindings
| 2.4 | 3 |
| 2.5 | 3 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: SQL Breadcrumb with bindings
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -93,6 +97,8 @@ Scenario Outline: SQL Breadcrumb with bindings
| 2.4 | 5 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Active job breadcrumb
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -117,6 +123,8 @@ Scenario Outline: Active job breadcrumb
| 2.4 | 5 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Cache read
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -138,3 +146,5 @@ Scenario Outline: Cache read
| 2.4 | 5 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
6 changes: 6 additions & 0 deletions features/rails_features/handled.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ Scenario Outline: Unhandled RuntimeError
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Thrown handled NameError
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -72,6 +74,8 @@ Scenario Outline: Thrown handled NameError
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Manual string notify
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -104,3 +108,5 @@ Scenario Outline: Manual string notify
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
6 changes: 5 additions & 1 deletion features/rails_features/ignore_classes.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Scenario Outline: Ignore_classes can be set to a different value in initializer
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Ignore_classes can be set to a different value after initializer
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -50,4 +52,6 @@ Scenario Outline: Ignore_classes can be set to a different value after initializ
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
2 changes: 2 additions & 0 deletions features/rails_features/meta_data_filters.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,5 @@ Scenario Outline: Meta_data_filters should include Rails.configuration.filter_pa
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
11 changes: 10 additions & 1 deletion features/rails_features/mongo_breadcrumbs.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ Scenario Outline: Successful breadcrumbs
| 2.3 | 5 |
| 2.4 | 5 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Breadcrumb with filter parameters
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -70,6 +73,9 @@ Scenario Outline: Breadcrumb with filter parameters
| 2.3 | 5 |
| 2.4 | 5 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Failure breadcrumbs
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -97,4 +103,7 @@ Scenario Outline: Failure breadcrumbs
| 2.3 | 4 |
| 2.3 | 5 |
| 2.4 | 5 |
| 2.5 | 5 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
6 changes: 6 additions & 0 deletions features/rails_features/project_root.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ Scenario Outline: Project_root should default to Rails.root
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Project_root can be set in an initializer
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -67,6 +69,8 @@ Scenario Outline: Project_root can be set in an initializer
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Project_root can be set after an initializer
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -98,3 +102,5 @@ Scenario Outline: Project_root can be set after an initializer
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
8 changes: 7 additions & 1 deletion features/rails_features/release_stage.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ Scenario Outline: Release_stage should default to RAILS_ENV
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Release_stage can be set in an initializer
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -60,6 +62,8 @@ Scenario Outline: Release_stage can be set in an initializer
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Release_stage can be set after an initializer
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand All @@ -86,4 +90,6 @@ Scenario Outline: Release_stage can be set after an initializer
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
4 changes: 4 additions & 0 deletions features/rails_features/send_code.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Scenario Outline: Send_code can be updated in an initializer
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |

Scenario Outline: Send_code can be updated after an initializer
Given I set environment variable "RUBY_VERSION" to "<ruby_version>"
Expand Down Expand Up @@ -58,3 +60,5 @@ Scenario Outline: Send_code can be updated after an initializer
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
4 changes: 3 additions & 1 deletion features/rails_features/send_environment.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,6 @@ Scenario Outline: Send_environment should send environment in handled errors whe
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
4 changes: 3 additions & 1 deletion features/rails_features/unhandled.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,6 @@ Scenario Outline: Unhandled RuntimeError
| 2.4 | 5 |
| 2.5 | 3 |
| 2.5 | 5 |
| 2.5 | 6 |
| 2.5 | 6 |
| 2.6 | 5 |
| 2.6 | 6 |
Loading