Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Sidekiq 7 #785

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Add support for Sidekiq 7 #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
725acd0
Add support for Sidekiq 7
stevenharman Jul 7, 2023
013c89c
Add currently supported Rubies for Sidekiq matrix
stevenharman Jul 7, 2023
a9de6e4
Limit number of Sidekiq jobs run on CI
imjoehaines Jul 14, 2023
63048a5
Update changelog
imjoehaines Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/maze-runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,15 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: ['2.5']
sidekiq-version: ['2', '3', '4', '5', '6']
ruby-version: ['2.5', '2.7']
sidekiq-version: ['2', '3', '4', '5', '6', '7']
include:
- ruby-version: '3.2'
sidekiq-version: '7'
exclude:
# 2.7 is the minimum ruby version that sidekiq 7 supports
- ruby-version: '2.5'
sidekiq-version: '7'

uses: ./.github/workflows/run-maze-runner.yml
with:
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
Changelog
=========

## TBD

### Enhancements

* Support Sidekiq v7
| [#785](https://github.com/bugsnag/bugsnag-ruby/pull/785)
| [stevenharman](https://github.com/stevenharman)

## v6.25.2 (7 February 2023)

### Enhancements
Expand Down
1 change: 1 addition & 0 deletions lib/bugsnag/integrations/sidekiq.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module Bugsnag
##
# Extracts and attaches Sidekiq job and queue information to an error report
class Sidekiq
include ::Sidekiq::ServerMiddleware if defined?(::Sidekiq::ServerMiddleware)

unless const_defined?(:FRAMEWORK_ATTRIBUTES)
FRAMEWORK_ATTRIBUTES = {
Expand Down
Loading