Call getUserIdentifier
instead of getUsername
on Symfony 6
#145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We automatically detect the logged in user's ID, which currently uses
getUsername
to fetch an identifier:bugsnag-symfony/DependencyInjection/ClientFactory.php
Lines 391 to 393 in d094e0e
Symfony 5.3 deprecated
getUsername
and introducedgetUserIdentifier
to replace it. Symfony 6.0 has subsequently removedgetUsername
, leaving onlygetUserIdentifier
. This causes a crash as we're calling a method that may not exist (older code bases may still implementgetUsername
in addition togetUserIdentifier
)See #141
Testing
I've added a Maze Runner test for our user detection logic on Symfony 4 and 6. This covers both the
getUsername
branch, as well as thegetUserIdentifier
branchI'll add the same test setup for Symfony 2 & 5 separately, to avoid making this PR too huge